Skip to content

Clarify tls settings for OIDC providers #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2024
Merged

Clarify tls settings for OIDC providers #659

merged 3 commits into from
Sep 10, 2024

Conversation

NickLarsenNZ
Copy link
Member

Fixes #654.

  • Add example TLS configuration for the OIDC provider.
  • Make it clear that TLS is disabled if that section is not present.

@NickLarsenNZ NickLarsenNZ self-assigned this Sep 10, 2024
@NickLarsenNZ
Copy link
Member Author

Here's a preview:

image

(I have checked the added link too)

@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 06f44f2
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/66e0311ddb8bd00008110639
😎 Deploy Preview https://deploy-preview-659--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickLarsenNZ NickLarsenNZ changed the title Clarify tls settings for oidc prodivers Clarify tls settings for OIDC providers Sep 10, 2024
sbernauer
sbernauer previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

@NickLarsenNZ @sbernauer
Update modules/concepts/pages/authentication.adoc
06f44f2 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 173f247 Sep 10, 2024
7 checks passed
@NickLarsenNZ NickLarsenNZ deleted the improve-oidc-tls-docs branch September 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention TLS server verification in AuthClass OIDC docs
2 participants
@NickLarsenNZ @sbernauer